Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning when an invalid host is specified via '-x' #250

Open
mattsfuller opened this issue Sep 8, 2016 · 0 comments
Open

Display a warning when an invalid host is specified via '-x' #250

mattsfuller opened this issue Sep 8, 2016 · 0 comments

Comments

@mattsfuller
Copy link

On a four node cluster with master, slave1, slave2 and slave3, when I run a presto-admin command say connector add hive and specify an invalid host name via -x, no warning is displayed about the host being invalid.
$./prestoadmin/presto-admin connector add hive -x blah
Deploying hive.properties connector configurations on: master
Deploying hive.properties connector configurations on: slave1
Deploying hive.properties connector configurations on: slave2
Deploying hive.properties connector configurations on: slave3
I suspect that this behavior is true for all presto-admin commands that support -x option, though I haven't tried it for all the commands.
Also opened the PR: #159
You may want to add a negative test for presto admin commands for this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant