Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use my own image_uri with download_uri #96

Open
yvanngn opened this issue Oct 26, 2023 · 1 comment
Open

Can't use my own image_uri with download_uri #96

yvanngn opened this issue Oct 26, 2023 · 1 comment
Assignees

Comments

@yvanngn
Copy link

yvanngn commented Oct 26, 2023

Hi,

Thanks for the bundle, it works well.
It would be nice to be able to overwrite the dowload_uri option with my own because it depends on the bool dowload_link and is forced to the location of the image

if ($options['download_link'] && $form->getParent()->getData()) {
    $view->vars['download_uri'] = $this->storage->resolveUri($form->getParent()->getData(), $form->getName());
}

(

if ($options['download_link'] && $form->getParent()->getData()) {
$view->vars['download_uri'] = $this->storage->resolveUri($form->getParent()->getData(), $form->getName());
}
)

The dowload_link seems not necessary too.
Maybe we can add another option image_uri to overwrite the location and let the dowload_uri because they are two differents options to have a behavior close to VichImage.

Thank you

J-Ben87 added a commit that referenced this issue Oct 27, 2023
@J-Ben87 J-Ben87 self-assigned this Oct 27, 2023
J-Ben87 added a commit that referenced this issue Oct 27, 2023
@J-Ben87
Copy link
Member

J-Ben87 commented Jan 4, 2024

Hi @yvanngn

If I'm right everything is good here. Can I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants