unit testing without postgres dependency (mock)

[avelino]

Discussed in #562

^{Originally posted by avelino June 23, 2021}
The postgres adapter depends on the postgreSQL (database) server to run (go test), i.e. it was developed with integration testing.

Integration testing is necessary, but it raises the barrier for new members to contribute, i.e. for a person to make any contribution he needs to learn to configure the development environment and only then contribute. I think it's great to have people immersed in the project, but this is not the reality of open source projects that people contribute in their spare time (usually without pay)

I don't think it is necessary to "remove" the integration test but put it in its place:

1. unit test that does not depend on external services (e.g. PostgreSQL) running with go test ...., so our people were able to run the tests locally (on their machines)
2. Integration test: run only on CI (GitHub Actions or Travis CI) on pull request - doesn't necessarily have to be written with go test

What would be the best option to write postgres adapter mock?

Ref:

• Improve local tests execution #510
• Change TravisCI to GitHub Actions  #555
• Report for F ... is for lots of things to Fix! #558
• ./adapters/test.sh - could not load $HOME/queries/fulltable/patch_all.update.sql #472
• … as we see above we have several issues related to this subject - sad

[vmesel]

Is this still open?

[avelino]

Is this still open?

@vmesel yep, we need to rewrite the tests with unit tests in mind, this simplifies the way to run the tests for the incoming contributors

Leave the integration test (e2e) as we do for the build process (in the pipeline, even so we need to think if it is necessary)