Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist markdownCodeBlock #61

Open
Porges opened this issue Sep 4, 2017 · 2 comments
Open

Blacklist markdownCodeBlock #61

Porges opened this issue Sep 4, 2017 · 2 comments

Comments

@Porges
Copy link

Porges commented Sep 4, 2017

With tpope/vim-markdown, I think markdownCodeBlock should also be blacklisted.

At the moment there is:

    \     'black': [
    \       'htmlH[0-9]',
    \       'markdown(Code|H[0-9]|Url|IdDeclaration|Link|Rule|Highlight[A-Za-z0-9]+)',
    \       'markdown(FencedCodeBlock|InlineCode)',
    \       'mkd(Code|Rule|Delimiter|Link|ListItem|IndentCode|Snippet)',
    \       'mmdTable[A-Za-z0-9]*',
    \     ],
    \     'white': [
    \      'markdown(Code|Link)',

... so it looks like markdownCodeBlock would be blacklisted and then whitelisted again. Perhaps the blacklist should be markdownCodeBlock and then the whitelist for markdownCode could be removed?

@Porges
Copy link
Author

Porges commented Sep 4, 2017

I'm also not seeing the fenced code blocks (with tpope's version) get blacklisted. This might be complicated because it supports nested syntax highlighting in fenced code blocks. Should I open a separate issue for this?

@reedes
Copy link
Collaborator

reedes commented Sep 10, 2017

The intent of the odd whitelisting was to allow for unfenced inline code examples such as this to be wrapped via autoformat, or rather to avoid disabling of autoformat where they are present. But it's been a long time since I last visited that behavior. In addition, the syntax plugins may have changed to break the black/whitelists.

Attaching any examples to this issue that demonstrate undesirable behavior would be fine. I'll then try to reproduce in the next week or so. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants