PHP Error Notices - Undefined index when PHP is run from the command line

[lencioni]

When a script is run from the command line, three notices are generated in external/header.php:

Undefined index: REMOTE_ADDR in external/header.php on 16
Undefined index: REQUEST_URI in external/header.php on 39
Undefined index: REMOTE_ADDR in external/header.php on 5

[preinheimer]

Hrm...

I hadn't really considered the use case of running this from the command line, so the request parameters are presumed to exist. Any suggestions on the best way to handle this?

paul

[lencioni]

Yeah, running PHP from the command line typically doesn't happen for us except for cron jobs.

You could either determine if it is being run from the command line and then have it skip out on xhprof (so the command line stuff wouldn't be ever profiled) or you could add some isset() checks for each of these.

For example, line 5 would be:

if(isset($_SERVER['REMOTE_ADDR']) && in_array($_SERVER['REMOTE_ADDR'], $controlIPs) && isset($_GET['_profile']))

and line 16 would be:

if (isset($_SERVER['REMOTE_ADDR']) && in_array($_SERVER['REMOTE_ADDR'], $controlIPs) && (isset($_COOKIE['_profile']) && $_COOKIE['_profile']))

[lencioni]

Also found Undefined index: REQUEST_URI in utils/xhprof_runs.php on 424

[lencioni]

I'm thinking that if REQUEST_URI doesn't exist, you might be able to substitute $_SERVER['PHP_SELF'] which would be the path of the file that is being run.

[lencioni]

Also found

Undefined index: c_url in xhprof_html/index.php on 167
Undefined index: timestamp in xhprof_html/index.php on 171

when requesting /xhprof_html/?hit=50&days=1

[preinheimer]

#23 might help a bunch of items.