Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected upload #131

Open
vweevers opened this issue Aug 12, 2016 · 1 comment
Open

Unexpected upload #131

vweevers opened this issue Aug 12, 2016 · 1 comment
Labels
enhancement New feature or request

Comments

@vweevers
Copy link
Member

I accidentally uploaded a release to leveldown last night, not realizing:

  1. I previously created a global .prebuildrc with upload=<token>, for a different project.
  2. In this case, prebuild --all means prebuild --all --upload
  3. prebuild takes the GH repo from package.json, so work you do in a fork will still be uploaded to the upstream repo

So I'm wondering if:

  1. We could add a github-token flag. You'd put this in rc, and then to upload, you'd have to explicitly run prebuild --upload. The existing --upload=<token> form would be a shortcut to --upload --github-token=<token>
  2. The GH repo should be configurable, or maybe taken from git remotes. Not sure what works for everyone
@juliangruber
Copy link
Collaborator

oops that's not good! i think the main problem is that upload=<token> in any configuration makes prebuild take that as an upload command, so I vote for renaming one of the two to make it explicit, as we've done before with another flag that I can't remember right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants