You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I accidentally uploaded a release to leveldown last night, not realizing:
I previously created a global .prebuildrc with upload=<token>, for a different project.
In this case, prebuild --all means prebuild --all --upload
prebuild takes the GH repo from package.json, so work you do in a fork will still be uploaded to the upstream repo
So I'm wondering if:
We could add a github-token flag. You'd put this in rc, and then to upload, you'd have to explicitly run prebuild --upload. The existing --upload=<token> form would be a shortcut to --upload --github-token=<token>
The GH repo should be configurable, or maybe taken from git remotes. Not sure what works for everyone
The text was updated successfully, but these errors were encountered:
oops that's not good! i think the main problem is that upload=<token> in any configuration makes prebuild take that as an upload command, so I vote for renaming one of the two to make it explicit, as we've done before with another flag that I can't remember right now.
I accidentally uploaded a release to leveldown last night, not realizing:
.prebuildrc
withupload=<token>
, for a different project.prebuild --all
meansprebuild --all --upload
package.json
, so work you do in a fork will still be uploaded to the upstream repoSo I'm wondering if:
github-token
flag. You'd put this in rc, and then to upload, you'd have to explicitly runprebuild --upload
. The existing--upload=<token>
form would be a shortcut to--upload --github-token=<token>
The text was updated successfully, but these errors were encountered: