Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full size error #1136

Open
acastrovargas opened this issue Jan 15, 2024 · 7 comments
Open

Full size error #1136

acastrovargas opened this issue Jan 15, 2024 · 7 comments

Comments

@acastrovargas
Copy link

The full size is not real, it only shows the value of files and not the contents in the folders.

CinNg8j

@explorerfaketimepass
Copy link

#1100 Check out this PR, as it implements a feature to display disk space usage.

@acastrovargas
Copy link
Author

The PR is still not integrated?

@ner00
Copy link
Contributor

ner00 commented Jan 24, 2024

Just note that the script will have to iterate through every sub-folder and its contents to calculate this, every time the page refreshes. I had implemented this on a custom version of mine but had to turn if off due to the performance impact. If you have few files and all with a certain acceptable size, no problem, otherwise the HDD will be taxed immensely.

@acastrovargas
Copy link
Author

Thanks, I was about to implement, for this reason I will not do it

@hppanpaliya
Copy link

@ner00 No, the script does not iterate through every sub-folder and its contents to calculate disk space. It uses efficient built-in PHP functions (disk_total_space() and disk_free_space()) that directly query the operating system, so it won't heavily tax the HDD.

@ner00
Copy link
Contributor

ner00 commented Jan 24, 2024

@hppanpaliya my misunderstanding then, I was thinking of folder file size, which is obviously different and that does have to work in the way I described.

@acastrovargas
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants