Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Short description of the feature #1371

Open
Nidhogblo opened this issue Apr 23, 2024 · 6 comments
Open

[Feature Request]: Short description of the feature #1371

Nidhogblo opened this issue Apr 23, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Nidhogblo
Copy link

Nidhogblo commented Apr 23, 2024

Feature Request

Asus Drivers incorporations

Description

Hi, I work in a drivers incorporation for Asus laptops, I made a little script to detect Asus computers and the incorporation of the drivers in the computer and add this in the pacman for the updates, all work really well, but I don't know where can I put this script to incorporate in the code (I see the globals_fn.sh,but i don't know where is the correct form to push mi changes ,for do the pr)

Use Case

This is really useful for the control of specials things of laptops asus,like a fan controler, special keys ,lights and other features

Proposed Solution

the connection to specials drivers to do this and the add this on pacman :)

Additional Information

These features can be added to aspector visuals or other tools such as way bar synchronisation with fan control,etc.

the packages are:
asusctl
asusctlAUR is a CLI utility for ASUS ROG & TUF laptop, to name some of the important features it gives users control over:
Integrated GPU MUX Control
Keyboard RGB Lighting Profile (but limited compared to the Windows AURA/Armoury Crate)
Fan Curves
Battery Charge Limit
Panel Overdrive
AniMe Matrix Screens

For usage instructions see asusctl.
supergfxctl

supergfxctlAUR is a CLI utility for managing GPU switching functionality on ASUS hybrid laptops, particularly dedicated GPU MUX control.

For usage instructions see supergfxctl.
rog-control-center

rog-control-centerAUR is a GUI frontend for asusctl and supergfxctl.

more info:
https://wiki.archlinux.org/title/ASUS_Linux
https://asus-linux.org/guides/arch-guide

@Nidhogblo Nidhogblo added the enhancement New feature or request label Apr 23, 2024
@dieBakterie
Copy link
Contributor

dieBakterie commented Apr 23, 2024

Like this you can do it yourself for now. Propably will be added when enough people want it to be added.
HyprV4 by SolDoesTech @kRHYME7 for ref/what's all needed If you want to implement this. It's from SolDoesTech and i Like the Feature with the Keyboard Setup and metric/imperial system and some other stuff but sadly it's deprecated i think.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Apr 23, 2024

I remove it for a while in the CLI just to adjust on some changes (Hyprdots > > > Hyde )

https://github.com/kRHYME7/Hyde-cli/blob/2db3ec5b5bc260d0254d5af44744961d89ad5b97/Hyde#L504C1-L521C9

@prasanthrangan
Copy link
Owner

prasanthrangan commented Apr 23, 2024

where can I put this script to incorporate in the code (I see the globals_fn.sh,but i don't know where is the correct form to push mi changes ,for do the pr)

Hey @Nidhogblo , the packages you have listed looks very specific to some asus laptops. So if you have a quick and easy way to detect the laptop model, then you can add your logic before this line to append install_pkg.lst -

hyprdots/Scripts/install.sh

Lines 137 to 141 in e3a07cc

#--------------------------------#
# install packages from the list #
#--------------------------------#
"${scrDir}/install_pkg.sh" "${scrDir}/install_pkg.lst"

@Nidhogblo
Copy link
Author

I remove it for a while in the CLI just to adjust on some changes (Hyprdots > > > Hyde )

https://github.com/kRHYME7/Hyde-cli/blob/2db3ec5b5bc260d0254d5af44744961d89ad5b97/Hyde#L504C1-L521C9

Yeah,I see the change and the project is really interesting ,if they need help,i could help us with code or with the documentation :D

@Nidhogblo
Copy link
Author

where can I put this script to incorporate in the code (I see the globals_fn.sh,but i don't know where is the correct form to push mi changes ,for do the pr)

Hey @Nidhogblo , the packages you have listed looks very specific to some asus laptops. So if you have a quick and easy way to detect the laptop model, then you can add your logic before this line to append install_pkg.lst -

hyprdots/Scripts/install.sh

Lines 137 to 141 in e3a07cc

#--------------------------------#
# install packages from the list #
#--------------------------------#
"${scrDir}/install_pkg.sh" "${scrDir}/install_pkg.lst"

Hi ,I do the implementation in the code and it works fine,do you want to do a pr? ,I think my code could be better organised with the project format but for the moment it is functional and fine.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Apr 30, 2024

@Nidhogblo Hello🌊

Can you check if Hyde inject asus_patch works. Update the cli first yay -Sy hyde-cli-git .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants