Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.3 change breaks usage with Vite #258

Open
2 tasks done
dbruning opened this issue Jun 22, 2022 · 5 comments
Open
2 tasks done

v6.0.3 change breaks usage with Vite #258

dbruning opened this issue Jun 22, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@dbruning
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you updated Vue FilePond, FilePond, and all plugins?

  • I have updated FilePond and its plugins

Describe the bug

To fix #122 vue-filepond v6.0.3 introduced a change to replace:
import Vue from 'vue'
with:
import Vue from 'vue/dist/vue.esm';

Unfortunately this fix breaks the usage of vue-filepond under vite. It causes Vite to include a complete new copy of Vue, which basically re-introduces exactly the problem that #122 was trying to solve ("$attrs is readonly")

The workaround is just to go back to v6.0.2 under Vite. I'm not knowledgeable enough to know how to make a change that will work under both vue-clie(/webpack) and Vite; but hopefully this will help someone in future.

Reproduction

Try to use vue-filepond with vue2 and vite

Environment

- Device: Windows PC
- OS: Windows
- Browser: any
- Vue version: 2.6.14
@dbruning dbruning added the bug Something isn't working label Jun 22, 2022
@simonmaass
Copy link

I just ran into the same issue

@rikschennink
Copy link
Collaborator

I'm currently working on a new version of FilePond and will also re-visit types.

@smortexa
Copy link

any news?

@productdevbook
Copy link

productdevbook commented Dec 15, 2022

@rikschennink Thank you, Is there any news and it will be great if you support TS completely.

@rikschennink
Copy link
Collaborator

I'll be using JSDoc comments for v5, I believe that is compatible with TS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants