Window resizes incorrectly on startup (Linux/Wayland)

[Kitt3120]

Type

Game behaviour

Bug description

When starting up the game on Linux using Wayland and the SDL_VIDEODRIVER=wayland environment variable, the window resizes to an incorrect size.

• It happens on both, the OpenGL (legacy) and the OpenGL renderer.
• It happens on Windowed, Borderless and Fullscreen.
• It happens when using the "Default" resolution and when specifying a resolution manually.

As soon as any of the graphics layout settings are changed, and the game "refreshes", it scales to the correct size.

On my 2560x1440@240 screen, it initially scales to 1365x767, which is about 53% my screen's size.

It hasn't done this 4 days ago. That should've been on 2023.1224.0.

Screenshots or videos

2023-12-29_21-43-16.mp4

Sorry, video doesn't seem to play in Firefox.

Version

2023.1229.1

Logs

compressed-logs.zip

[Kitt3120]

This might be something more. I found out that my tablet also doesn't work in osu anymore until I toggle a specific setting on and off again.

To be clear, on Wayland you have to disable "High precision mouse" to get OpenTabletDriver working in osu. This has always been the case and that's okay.

But now, I have to enable and again disable this setting to get my tablet working on each startup.

It seems as if osu starts with some default values and does not consider some saved settings anymore.

This video shows me using my tablet outside of osu (working), when starting up osu (not working) and after toggling "High precision mouse" on and off again (working).

2023-12-30_14-00-28.mp4

[memesnightmares]

This is not a wayland issue, I would guess it has to do with your specific DE not wayland in general. I run sway with the same SDL_VIDEODRIVER env var and I don't experience any issues (game works both with/without high precision mouse enabled and setting persists across restarts, tested on 2023.12.29.1). It is something else about your setup. From my understanding of this projects stance on linux, if you want this to be resolved, it may be helpful to go through and find the specific commit/code change that introduced the issue (a good starting point might be before/after 1233533).

[Kitt3120]

As there is not "one wayland" (Wayland is just a protocol on paper), it seems that Sway's Wayland handles this correctly and Plasma's Wayland implementation does not.

Good point, I'll try to narrow down the specific commit.

[Susko3]

Probably a regression from updating SDL2 in ppy/osu-framework@985922d.

If you're willing, you can try looking for the regression with https://github.com/libsdl-org/SDL/tree/SDL2 itself.

[Kitt3120]

Thanks for the tip. I'll look into it if I find the time to do so.

[THEGOLDENPRO]

This issue seemed to begin for me after the 2023.1229.1 update.

I'm gonna bring what I said at ppy/osu-framework#6094 (comment) over here:

It seems like ever since this release my game has been launching like the image below despite it being in fullscreen mode.

Toggling fullscreen mode on and off seems to temporarily fix it but it occurs once again when I relaunch.

• OS: Arch Linux x86_64
• DE: KDE Plasma 5.27.10
• Kernel: 6.6.9-arch1-1

Let me know if you need anything else, thank you.

[Kitt3120]

Okay, I finally found the time to set the project up on my linux machine. It was a hassle to get dotnet 6 with Roslyn support working. As Arch's packaging of dotnet somehow has Roslyn disabled, I had to use Microsoft's install script, which installs dotnet in user-space and move it into the system dirs manually.

Anyways, I am able to reproduce the error on a fresh build with default settings. Time to bisect!

Edit: Summary of the below conversation

osu:
    Last good: b53e7305b4
    First bad: 1233533fb967390c2c433ea0f7feb0dadd682635

Resulting in...
osu-framework:
    Last good: 2023.1227.0
    First bad: 2023.1227.1
    Commits between releases: https://github.com/ppy/osu-framework/compare/2023.1227.0...2023.1227.1

Resulting in...
SDL2-CS:
    Last good: 1.0.671-alpha
    First bad: 1.0.693-alpha
    Commits between releases:
      From: https://github.com/ppy/SDL2-CS/compare/e4afbb848586fca530b6538320f799f81a18b941
      To: https://github.com/ppy/SDL2-CS/commit/c4976a1cc1bcbb64ef6600d157cdf021179a5899
      (Can't get GitHub compare view to work on this)

Resulting in...
Upstream error in SDL-CS wrapper by flibitijibibo (https://github.com/flibitijibibo/SDL2-CS)
or SDL itself (https://github.com/libsdl-org/SDL).

Related SDL issues/PRs in relevant timespan:
  - https://github.com/libsdl-org/SDL/issues/7961
  - https://github.com/libsdl-org/SDL/pull/8013

Which could mean that this is actually expected behaviour from SDL and fixed a possible segfault.
The KDE Plasma Wayland compositor would be to blame here for reporting wrong dimensions.

[Kitt3120]

This seems related: libsdl-org/SDL#8013
Could this have possibly introduced this? If so, this is actually expected behaviour from SDL and fixed a possible segfault. The KDE Plasma Wayland compositor would be to blame here for reporting wrong dimensions.

To test this, tomorrow I'll set up VMs with some Plasma and Gnome distros. Maybe Gnome's Wayland compositor behaves differently. Or, if someone wants to help, please go ahead and feel free to do so and report back here :)

[Susko3]

For testing this, I suggest you build libSDL2.so from source, copy it into the osu! directory (whatever that means on linux) and then run it. At least that's the way I tested it on Windows with copying DLLs. To avoid manually packing SDL2-CS.

You could check SDL_GetVersion() to make sure it's using the libSDL2.so you gave it.

It's also possible we're doing something slightly wrong in the startup sequence, so the entirety of the fault may not be with SDL. But it would still be useful to track down the offending commit.

[Kitt3120]

Hey, it's been a while. Did not have much time to further work on this, and I won't have some time for now. Still, I took a moment to set up a fresh NixOS VM with Plasma 6 and the behaviour is the same. So I am sure that it has nothing to do with my personal setup/environment. Will try out GNOME soon.

[THEGOLDENPRO]

yeah sadly this issue hasn't gone away for me, I've just gotten used to re-toggling full-screen. 😅

Also shouldn't this be converted into an actual issue. @Kitt3120

[Kitt3120]

This originally was an issue and has been converted to a conversation. I'll let the moderators here manage this.

As I have a NixOS VM now, it should be easy to switch between Wayland compositors. I'll try GNOME's mutter and other Wayland compositors soon.

[THEGOLDENPRO]

If anyone wants a lazy temporary solution I made a tiny python script that automatically full screens osu! on launch: https://github.com/THEGOLDENPRO/kde-osu-fullscreen-fix

[Kitt3120]

It's fixed for me now in 2024-412-1. The game still briefly starts with the wrong dimensions and fixes itself as soon as it gets focused. This also fixed the problems I had with my tablet.

It's worth mentioning that it always worked on my NixOS machine. It was just broken on my Arch installation. Weird. Probably SDL2, maybe I'll investigate it when I have some time. Good thing is that it works for now x)

Edit: Well, my tablet is not really fixed. It works again initially, but it's completely offset to my actual settings and has wrong sensitivity. It's like osu re-maps the tablet input. Tablet input is disabled in osu so it uses my OpenTabletDrivers. It's fixed by, just like before, cycling through windowed, borderless and fullscreen again.

[Susko3]

Please give it a try again in the latest version! We've switched to SDL3, so things might have changed.

[Kitt3120]

You guys made me curious, so I left osu! open for a bit longer. It actually started switching between fullscreen and being glitched like every 5 seconds on its own. Yup, it's not working xD

Okay, the SDL3 revert explains a lot.

[Kitt3120]

Good news: osu-framework already has SDL3 re-enabled again! So next release will probably have SDL3 back. For now, you can enable SDL3 by starting osu! with OSU_SDL3=1 according to this.

https://github.com/ppy/osu-framework/releases

Edit:

Can confirm SDL_VIDEODRIVER=wayland OSU_SDL3=1 osu-lazer working fine

[Neon095]

For me its not working even with the osu sdl3. When i receive any system notification the games goes to windowed mode for a few seconds. This didn't happened before the revert

2024-05-25.10-09-11.mp4

For example, this is what happens when i mute the audio

[Susko3]

OSU_SDL3=1 doesn't do anything in the current release. You'll have to wait for the next one (probably).

[Kitt3120]

Alright, thanks for clearing up :)