Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow one drag event at a time #6102

Open
peppy opened this issue Jan 3, 2024 · 0 comments
Open

Only allow one drag event at a time #6102

peppy opened this issue Jan 3, 2024 · 0 comments

Comments

@peppy
Copy link
Sponsor Member

peppy commented Jan 3, 2024

Currently, when a game specified that drags can be initiated by more than just left mouse via..

/// <summary>
/// Whether dragging is handled by the managed button.
/// </summary>
public abstract bool EnableDrag { get; }

.. one OnDragStart event triggers per mouse button. I'd argue that this shouldn't be the case, and once a drag operation is started no more can trigger until that operation ends.

The current behaviour can lead to oversights as an average framework consumer would not expect multiple concurrent drag operations to be a thing.

This caused the failure here: ppy/osu#26353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant