Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriggerPressed/Released doesn't follow propogation expectations. #6037

Open
LumpBloom7 opened this issue Oct 27, 2023 · 0 comments
Open

TriggerPressed/Released doesn't follow propogation expectations. #6037

LumpBloom7 opened this issue Oct 27, 2023 · 0 comments
Labels
area:input priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@LumpBloom7
Copy link
Contributor

LumpBloom7 commented Oct 27, 2023

Relevant discord thread: https://discord.com/channels/188630481301012481/589331078574112768/1167049871199584306

The RulesetInputManager sends replay actions via KeyBindingContainer.TriggerPressed/TriggerReleased.

KeyBindingContainer.TriggerPressed/Released doesn't go through the handleNewPressed/handleNewReleased flow (where the inputQueue used is trimmed as needed); Instead TriggerPressed/Released will create a completely new queue, which includes all drawables present in the hierarchy, so all active drawables get the released event (since there is nothing to stop propogation like PropogationPressed), while drawables that handled OnPressed doesn't affect the input queues used by handleNewPressed/Released

This also has an impact on touch input handling, as on screen touch receptors used by osu rulesets utilize the trigger methods as well, which may be mixed with physical key presses (in the case of sentakki)

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:input priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

3 participants