Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter JSON Parser (avoid duplicate keys) #35

Open
pplu opened this issue May 23, 2019 · 0 comments
Open

Stricter JSON Parser (avoid duplicate keys) #35

pplu opened this issue May 23, 2019 · 0 comments

Comments

@pplu
Copy link
Owner

pplu commented May 23, 2019

The current JSON module doesn't detect duplicate keys when parsing JSON. This is dangerous, since we can inadvertantly accept JSON that we parse in one way, but CloudFormation understands in another.

Branch https://github.com/pplu/cfn-perl/tree/json_maybexs/, using JSON::MaybeXS is failing because when it loads JSON::XS there is no duplicate key detection https://travis-ci.org/pplu/cfn-perl/builds/536295416. It works when using Cpanel::JSON::XS.

Branch https://github.com/pplu/cfn-perl/tree/use_cpanel_json_xs, using Cpanel::JSON::XS is a quick test to verify that using Cpanel::JSON::XS, everything is working. Travis is reporting failures

@pplu pplu changed the title Stricter JSON Parser Stricter JSON Parser (avoid duplicate keys) May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant