Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve colors in the "Dark" score theme #357

Open
BigHonkinDaddy opened this issue Jan 9, 2022 · 7 comments
Open

Improve colors in the "Dark" score theme #357

BigHonkinDaddy opened this issue Jan 9, 2022 · 7 comments

Comments

@BigHonkinDaddy
Copy link

Description
The Dark score theme (accessed under File->Preferences->General is my preference and is useful especially for creating split screen videos that combine video of my performances with the video screen capture of the tabs from Powertab's Midi player. The "dark" them works best, visually, for this. However, the midi player controls (blue and red) are hard to see and follow in the dark theme. Furthermore, tied notes which are light grey are not easily distinguishable from the white notes/tabs in the dark theme.

Would love to see the color scheme under the "dark" theme improved - maybe even allow for users to assign their own colors to the midi player and score elements.

Lastly, the "Dark" theme seems only to apply to the score itself, leaving the menu bar, toolbar, mixer, and instrument windows still in the default light grey. Would like to see the "dark" theme apply to the entire application.

@cameronwhite
Copy link
Member

Yep, the score colours could definitely use a bit of tweaking!

The rest of the widgets are following the system theme, so if you have a dark theme set that should be respected (e.g. https://powertab.github.io/images/screenshot_macos.png) . It would be possible to add some customization on our end, though

@BigHonkinDaddy
Copy link
Author

Huh. I have my Windows 10 in "dark mode" but only see the original "light" version of PT. Not a huge deal, but wonder what I'm doing wrong...
Bug Example screen shot

@cameronwhite
Copy link
Member

Thanks, yeah looking around on Google it sounds like Qt doesn't handle the Windows dark theme yet, so we'll probably have to do something ourselves

@cameronwhite cameronwhite added this to the Alpha 17 milestone Jan 27, 2022
@cameronwhite cameronwhite removed this from the Alpha 17 milestone Jan 28, 2022
@cameronwhite
Copy link
Member

I've made some changes to tied notes and the caret to hopefully be better in the dark theme:
Before:
before
After:
after

@BigHonkinDaddy
Copy link
Author

Looks great!

@luzpaz
Copy link
Contributor

luzpaz commented Dec 15, 2023

Can this issue be closed ?

@cameronwhite
Copy link
Member

I think the remaining work here was to have a dark theme for the whole application, like for the Windows screenshot above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants