Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundaries for multipart requests in plain HTTP are incorrect #616

Open
thinkgruen opened this issue May 3, 2022 · 0 comments · May be fixed by #617
Open

Boundaries for multipart requests in plain HTTP are incorrect #616

thinkgruen opened this issue May 3, 2022 · 0 comments · May be fixed by #617
Labels

Comments

@thinkgruen
Copy link

Describe the bug
Currently, the Code Generator for (plain) HTTP is using the same boundary everywhere instead of following the RFC. When trying to send the generated code through an HTTP client, e.g. in IntelliJ, the IDE will point out that the boundaries are incorrect, and the request will fail.

To Reproduce
Steps to reproduce the behavior:

  • create a POST using a form-data body
  • add a key "foo" and text value "bar"
  • generate the HTTP code

Expected code snippet and corresponding request
The generated code is correct according to the definition of the aforementioned RFC which means:

  • there is a boundary defined alongside Content-Type: multipart/form-data (let's say xyz)
  • the boundary is used to separate different form data with two additional hyphens before (--xyz)
  • the request ends with a boundary with two leading and trailing hyphens (--xyz--)

Screenshots
All boundaries are identical but should follow the rules above.
A screenshot of the generated code

Additional context
Version of postman-code-generators/Postman app: 9.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants