Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node#before is deprecated. Use Node#raws.before #118

Closed
h0tc0d3 opened this issue May 17, 2017 · 8 comments
Closed

Node#before is deprecated. Use Node#raws.before #118

h0tc0d3 opened this issue May 17, 2017 · 8 comments

Comments

@h0tc0d3
Copy link

h0tc0d3 commented May 17, 2017

In latest version:

Node#before is deprecated. Use Node#raws.before
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot set property 'parent' of undefined
(node:6676) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 5): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 6): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 7): TypeError: Cannot set property 'parent' of undefined
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 8): TypeError: Cannot set property 'parent' of undefined

In v6.3.0 all fine. The bug is manifested with postcss-import postcss/postcss-import#285

@w0rm
Copy link
Member

w0rm commented May 17, 2017

gulp-postcss bumped the major version of PostCSS, so there may be incompatibilities with some plugins. Please check what plugins are broken, update them to the most recent versions, or open issues in the corresponding repositories. You can always use the previous version of gulp-postcss.

@w0rm w0rm closed this as completed May 17, 2017
@h0tc0d3
Copy link
Author

h0tc0d3 commented May 17, 2017

This bug manifests only in gulp-postcss + postcss-import. I disable all plugins and found this chain. These two plug-ins create this effect. If i install gulp-postcss@6.3.0 + postcss 6.0.1 then no errors and all works fine.

@w0rm
Copy link
Member

w0rm commented May 17, 2017

Does it work with gulp-postcss 6.4.0?

@w0rm w0rm reopened this May 17, 2017
@h0tc0d3
Copy link
Author

h0tc0d3 commented May 17, 2017

Work. Bug only in "gulp-postcss": "^7.0.0".

@w0rm
Copy link
Member

w0rm commented May 17, 2017

The only change between 6.4.0 and 7.0.0 was a bump of postcss from 5 to 6. So it must be related to this. This proves my first comment was correct.

@w0rm w0rm closed this as completed May 17, 2017
@jonathantneal
Copy link
Member

FWIW Node#before is deprecated. Use Node#raws.before is an unnecessary message in PostCSS itself that you receive when following the correct usage.

@AntonioRedondo
Copy link

I have the same issue described by @h0tc0d3. However the error message go when commenting out the precss plug-in. Is it worth it to open a bug report on your repo @jonathantneal?

@h0tc0d3
Copy link
Author

h0tc0d3 commented May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants