Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapper has trouble with special characters when using National Dex + National cows #6

Open
marcosins opened this issue Aug 19, 2017 · 2 comments

Comments

@marcosins
Copy link

After some trouble (mostly imagemagick) i managed to create cows for every pokemon in the national dex*.

The scrapper script has troubles when the alt attribute has special characters in it ("Tapu Koko", "Mr. Mime", "Type:Null"). I modified it a little to use https and read the src attribute that uses // instead of http:// or https://

I hope this is helpful 👍

scrap_data.sh.zip
NationalCows.zip

*Lycanroc Midnight form isn't listed in Bulbapedia's National Dex and it's too late to care now

@marcosins marcosins reopened this Aug 19, 2017
@marcosins
Copy link
Author

Sorry for the close/reopen, i'm too tired. Here's a screenshot in Terminator with multiple generation pokemon.
pokemonsaynationaldex

@marcosins marcosins changed the title Filename when using National Dex + National cows Scrapper has trouble with special characters when using National Dex + National cows label:bug Aug 19, 2017
@marcosins marcosins changed the title Scrapper has trouble with special characters when using National Dex + National cows label:bug Scrapper has trouble with special characters when using National Dex + National cows Aug 19, 2017
@nosrednawall
Copy link

thanks, you are the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants