Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or adjust ionRangeSlider CSS dependency #27

Open
gadenbuie opened this issue Mar 5, 2024 · 0 comments
Open

Remove or adjust ionRangeSlider CSS dependency #27

gadenbuie opened this issue Mar 5, 2024 · 0 comments
Assignees

Comments

@gadenbuie
Copy link
Contributor

From https://github.com/posit-dev/py-shinyswatch/tree/e6f097b792bbba61fc4c03b0bbc78e4ae422f0c1/shinyswatch/bsw5/cerulean , shinyswatch is only aware of the ionRangeSlider and is missing selectize and datepicker. (The bootstrap.min.css is equivalent to the shiny.min.css.)

May I request a PR to add those two files (to here)? Thank you!

Originally posted by @schloerke in posit-dev/py-shiny#1191 (comment)

Ideally, after the changes in posit-dev/py-shiny#1191, theme extension packages like shinyswatch should not need to compile component dependencies. Our goal is that these would be written to target Bootstrap 5 and make use of CSS variables such that changing out the core Bootstrap CSS is sufficient.

@gadenbuie gadenbuie self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant