Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions for shiny create #72

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update instructions for shiny create #72

wants to merge 4 commits into from

Conversation

wch
Copy link
Contributor

@wch wch commented Jan 18, 2024

This fixes #59.

@wch wch requested a review from gshotwell January 18, 2024 17:20
@github-actions github-actions bot temporarily deployed to pr-72 January 18, 2024 17:30 Destroyed
gshotwell
gshotwell reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@gshotwell gshotwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions which will replicate the old behaviour. I also think we want to add --launch-browser to the run command or change the text (it says that it'll launch a browser but it doesn't currently).

docs/comp-r-shiny.qmd Outdated Show resolved Hide resolved
docs/install.qmd Outdated Show resolved Hide resolved
wch and others added 3 commits January 19, 2024 11:07
@wch @gshotwell
Update docs/comp-r-shiny.qmd
08e915d 
Co-authored-by: Gordon Shotwell <gordon.shotwell@posit.co>
@wch @gshotwell
Update docs/install.qmd
c94ed45 
Co-authored-by: Gordon Shotwell <gordon.shotwell@posit.co>
@wch
Add --launch-browser
19d9e8b
@wch
Copy link
Contributor Author

wch commented Jan 19, 2024

Thanks for the feedback. I also added the --launch-browser option to the instructions.

@github-actions github-actions bot temporarily deployed to pr-72 January 19, 2024 17:17 Destroyed
@github-actions github-actions bot temporarily deployed to pr-72 January 19, 2024 17:17 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshotwell gshotwell gshotwell left review comments

@robertgv robertgv robertgv approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation page running command outdated
3 participants
@wch @gshotwell @robertgv