You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reflecting on #124, where we now pass Config to all Resources. Config just holds url and api_key, but we never access api_key anywhere. The only time we access api_key is in the Auth constructor, which only uses api_key and not url.
My first thought was that we should only be passing url around to the Resources, no need to keep the API key so visible in each object. But then I wondered if we should just eliminate the object entirely.
The text was updated successfully, but these errors were encountered:
Reflecting on #124, where we now pass
Config
to allResources
.Config
just holdsurl
andapi_key
, but we never accessapi_key
anywhere. The only time we accessapi_key
is in theAuth
constructor, which only usesapi_key
and noturl
.My first thought was that we should only be passing
url
around to theResources
, no need to keep the API key so visible in each object. But then I wondered if we should just eliminate the object entirely.The text was updated successfully, but these errors were encountered: