Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Config need to exist at all? #139

Open
nealrichardson opened this issue Apr 1, 2024 · 1 comment
Open

Does Config need to exist at all? #139

nealrichardson opened this issue Apr 1, 2024 · 1 comment
Labels
question Further information is requested

Comments

@nealrichardson
Copy link
Collaborator

Reflecting on #124, where we now pass Config to all Resources. Config just holds url and api_key, but we never access api_key anywhere. The only time we access api_key is in the Auth constructor, which only uses api_key and not url.

My first thought was that we should only be passing url around to the Resources, no need to keep the API key so visible in each object. But then I wondered if we should just eliminate the object entirely.

@tdstein
Copy link
Collaborator

tdstein commented Apr 3, 2024

I'm surprised we haven't needed to add any additional properties. But if additional system properties are needed, I would place them here.

Here's some other information that might need to go there in the future:

  • User-Agent
  • HTTP Timeout
  • Proxy configuration?
  • SSL certificate information?
  • Additional OS information
  • Logging / Verbosity settings

@tdstein tdstein added the question Further information is requested label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants