Fix Degiro PDF import #3831
Fix Degiro PDF import #3831
Conversation
Then please set this PR to draft. |
Welcome to github then. Push the next changes to the same branch -and they will end up in this pull request. We strive to always have a test case for PDF changes - that makes it save to do future changes. |
|
Fixing this importer seems a bit harder than I thought :). Especially lacking the RegEx skills to debug properly which RegEx is failing the testcase examples. Do you have any tips/tricks? or website that helps with parsing examples? |
I think you definitely picked the hardest importer at all. Degiro is a tricky beast. Because the format in the file is cumbersome and because of the many languages. This site https://regex101.com looks interesting in testing regular expression. Be sure to pick the Java flavor. |
|
I think the PR in #3992 is in better condition than mine :) It has the similair change regarding the decimal value. So shall we close this one? |
Okay 👍🏻 Closes |
Closes #3991
Ran into failure for a few months now that Degiro imports didnt work. Setup development environment to investigate and find the issue. Also looked at reports on the forum which had the same problem: https://forum.portfolio-performance.info/t/pdf-import-from-degiro/12145/135
04-10-2023 09:33 HANETF MANAGEMENT LTD. IE00BMYMHS24 XET XETA 73 6,8 EUR -496,40 EUR -496,40 EUR -3,00 EUR -499,40 EUR
The regex indicates that minimum is 2, so this PR changes only this certain situation. Need to investigate more if the other cases needs updating as well including a add a unit-test for it.
Therefor PR is still in progress.
Note: First time creating PR to fix bug issue on Github.