Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle time edge-cases #71

Open
porglezomp opened this issue Oct 5, 2018 · 0 comments
Open

Handle time edge-cases #71

porglezomp opened this issue Oct 5, 2018 · 0 comments

Comments

@porglezomp
Copy link
Owner

There are two edge-cases that I figured out during discussion on #69 that need to be tested and fixed. From that discussion:

Exploring the semantics of the is_scheduled policies:

@ every # day(s) should wait at least # days. I think this should be independent of the times during those days, so if you read it at midnight on one day, and the morning a week later, less than 7 days have elapsed, but it should be considered as 7 days. I think this one is handled incorrectly, and we need to count days of the week rather than number of days in the elapsed time.

@ on monday/tuesday/etc should require that it was last read before that day, and it is now that day or later. Currently, if you last read it sunday night, and it's marked as @ on monday, I believe it will currently think 0 days have passed, and so not realize that you went from sunday -> monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant