Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mass matrix in L2 projection #303

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix mass matrix in L2 projection #303

merged 1 commit into from
Jan 17, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Jan 17, 2024

Fixes #302

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (134db3c) 65.43% compared to head (75ee674) 65.42%.

Files Patch % Lines
src/polyfem/assembler/MatParams.hpp 33.33% 2 Missing ⚠️
src/polyfem/solver/AdjointNLProblem.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   65.43%   65.42%   -0.01%     
==========================================
  Files         262      262              
  Lines       32277    32279       +2     
==========================================
  Hits        21120    21120              
- Misses      11157    11159       +2     
Flag Coverage Δ
polyfem 65.42% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus merged commit c453d94 into main Jan 17, 2024
7 of 8 checks passed
@zfergus zfergus deleted the fix-L2-projection branch January 17, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge collapse cause Numerical Issue in solving L2 projection
1 participant