Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label.pixelOffset does not appear to work #107

Closed
rengrub opened this issue Feb 23, 2023 · 2 comments · Fixed by #121
Closed

Label.pixelOffset does not appear to work #107

rengrub opened this issue Feb 23, 2023 · 2 comments · Fixed by #121
Labels
enhancement New feature or request

Comments

@rengrub
Copy link
Contributor

rengrub commented Feb 23, 2023

I am unable to get Label.pixelOffset to work with a list of x/y values.
I would expect it to work like this:
label=Label(pixelOffset=[5,5])

but instead I can only make it work like this:
label=Label( pixelOffset=dict([("cartesian2", [5, 5])]) )

@astrojuanlu
Copy link
Member

Hi @rengrub, thanks for opening the issue. It's been a while since I last used CZML, their docs are a bit obscure and I also reckon that the czml3 API could be more compact.

Unfortunately I won't have time in the short term to look into this and confirm or deny whether the API you propose is consistent with the rest. In the meantime, you're welcome to send a PR, or better: to add more context on this based on the CZML spec.

@Stoops-ML
Copy link
Collaborator

Stoops-ML commented May 21, 2024

This seems to be a bug with Cesium where the pixelOffset property of Label should be able to accept a list of points and not just the Cartesian2Value (like the cartesian property of Position).

This can be shown by playing around with the label example on sandcastle.

I'm marking this as an enhancement as we need to add the Cartesian2Value type into CZML3 to work around this issue.

@Stoops-ML Stoops-ML added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants