Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parks pacific marine fish codes #10

Open
aylapear opened this issue Mar 9, 2022 · 6 comments
Open

Add parks pacific marine fish codes #10

aylapear opened this issue Mar 9, 2022 · 6 comments
Assignees

Comments

@aylapear
Copy link
Member

aylapear commented Mar 9, 2022

Your Idea

  • Add the fish codes from the Parks Canada marine study to the package
  • Add Lynn Lee as contributor
@aylapear
Copy link
Member Author

aylapear commented Mar 9, 2022

I suggest adding the new table as marineparks

@evanamiesgalonski & @joethorley What do you think the new table name should be?

@aylapear
Copy link
Member Author

aylapear commented Mar 9, 2022

We assume the codes should be added to the freshwaterfish as a crossrefence (like the CDCode and ABCode columns) for the ones that span both tables like salmon. Do you agree @evanamiesgalonski ?

@evanamiesgalonski
Copy link
Member

i think marineparksfish would be a good name for the new table. And yes I agree it would be good to have an FK column in freshwaterfish to join to the new table.

@joethorley
Copy link
Member

Yes agree with adding a FK to freshwater fish for where they match up.

@joethorley
Copy link
Member

Our other tables are called ab and cdc so pc would be most fitting but they may have codes for freshwater - so how about pcmarine?

@Alcon98
Copy link

Alcon98 commented Mar 10, 2022

Oh I like the way that sounds, really rolls off the tongue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants