Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiCad Plugin and Content Manager addition #28

Open
pointhi opened this issue Oct 30, 2021 · 14 comments
Open

KiCad Plugin and Content Manager addition #28

pointhi opened this issue Oct 30, 2021 · 14 comments
Labels
question Further information is requested

Comments

@pointhi
Copy link
Owner

pointhi commented Oct 30, 2021

Dear color theme contributors @poeschlr @esden @DX-MON @craftyjon @wykys

I was asked to add those color schemes into the Plugin and Content Manager repository. Thus I would like to ask if you are OK with adding you as author (please give me a name, and as contact info I will simply add your github user if you like). As license, I set this repo to CC0-1.0, but I can set a different license on your theme if you like.

Either you create a PR with the given metadata.json file, or I will create one if you are ok with it. The file looks like this and is added to the color-scheme-directory. The directory further has to include the color-scheme in json format which I can then bundle into a package.

{
    "$schema": "https://gitlab.com/qu1ck/kicad/-/raw/pcm/kicad/pcm/schemas/pcm.v1.schema.json#",
    "name": "solarized-light theme",
    "description": "solarized-light color theme",
    "description_full": "solarized-light color theme",
    "identifier": "theme-solarized-light",
    "type": "colortheme",
    "author": {
        "name": "Thomas Pointhuber",
        "contact": {
            "web": "https://github.com/pointhi/kicad-color-schemes/"
        }
    },
    "maintainer": {
        "name": "Thomas Pointhuber",
        "contact": {
            "web": "https://github.com/pointhi/kicad-color-schemes/"
        }
    },
    "license": "CC0-1.0",
    "resources": {
        "Github": "https://github.com/pointhi/kicad-color-schemes"
    },
    "versions": [{
        "version": "1.0",
        "status": "stable",
        "kicad_version": "5.99"
    }]
}
@pointhi pointhi added the question Further information is requested label Oct 30, 2021
@craftyjon
Copy link
Contributor

The two themes I added to this repo (kicad-classic and kicad-default) should not be included in the PCM as they are built-in to KiCad.

@dragonmux
Copy link
Contributor

dragonmux commented Oct 30, 2021 via email

@wykys
Copy link
Contributor

wykys commented Oct 30, 2021

I am also pleased with this initiative. Please enter a name Jan Vykydal.

@esden
Copy link
Contributor

esden commented Oct 30, 2021

The nord theme that I submitted is actually desigend by @jordiorlando I only did some conversion to add it here. I think the approval and credit should go to him. If it was up to me I would definitely be fine with getting the theme added. :)

@pointhi
Copy link
Owner Author

pointhi commented Oct 30, 2021

This is a sneak peek how it looks right now:

PCM example

@dragonmux
Copy link
Contributor

dragonmux commented Oct 31, 2021 via email

@pointhi
Copy link
Owner Author

pointhi commented Oct 31, 2021

@DX-MON maybe we can add a light and a dark Eagle theme. I suppose only the background color is different?

@pointhi
Copy link
Owner Author

pointhi commented Oct 31, 2021

As KiCad introduced various new color tags over time, it would be nice if all themes we include in the package manager have all colors assigned. I did this for solarized in this commit: c6a545a

@jordiorlando
Copy link

This looks great! And thanks for the credit @esden 😄

@Shackmeister
Copy link
Contributor

I have written a message to the person who provided the monokai theme on the forum.
Would be great to get in the content manager :)

@ANWatson
Copy link

ANWatson commented Jan 6, 2022

Personally, I'd be happy for the monokai theme to be available in a theme selector. My name's Ash Watson. I am not the creator of the colour set itself though, I just posted a modified config file text back in 2018. So really it shouldn't be up to me.
The original creator of monokai itself ought to be asked and credited. I have reached out to them.
For now, please hold off on including monokai until they give their blessing.

@poeschlr
Copy link
Contributor

Sorry for the late response. I kind of missed this (was somehow lost in my inbox)

I am ok with anyone using my work however they want.

@jordiorlando
Copy link

@pointhi is there a way for you to change @0xdec to @jordiorlando in the plug-in manager? Or perhaps I should open an issue in GitLab?
image

@Chrismettal
Copy link

Thanks for getting most themes into the addon manager already!

Any reason for Behave-dark to be missing from the manager though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

10 participants