Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domain Configuration Overwritten #52

Open
allthesignals opened this issue Aug 2, 2016 · 2 comments
Open

Custom Domain Configuration Overwritten #52

allthesignals opened this issue Aug 2, 2016 · 2 comments
Assignees

Comments

@allthesignals
Copy link

When using a custom domain, Github requires a CNAME file. I think this can be done through correct merging of old and new gh-pages branches, but if I understand correctly, ember github-pages:commit will destroy the branch and recreate it, removing any CNAME file that's committed to the branch. Use git push origin gh-pages:gh-pages -f with caution for this reason. Not sure if this is an issue with this add-on, but it's worth noting.

@allthesignals allthesignals changed the title Custom Domain Custom Domain Configuration Overwritten Aug 2, 2016
@knownasilya
Copy link
Contributor

Thanks for the caution. Will see if there is anything we can do.

@knownasilya knownasilya self-assigned this Aug 2, 2016
@byvlstr
Copy link

byvlstr commented Jan 28, 2017

Hi,

NOTE I could resolve the issue by putting the CNAME file in the "public" folder. Then GitHub automatically recognizes and sets the custom domain, even in the Settings UI

I wanted to add my custom domain. I did it in the GitHub interface but then stupidly did a pull (as the CNAME creation commit was from the Github web UI) on my code, which "destroyed" the whole local code. As this add-on is merging many files and not leaving much on the master branch which is online, I thought creating the CNAME locally in my project files would do it, but no... The CNAME file is not being pushed to the remote master.
Any ideas?

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants