Custom Settings Pages should support specifying a capability for access

[sc0ttkclark]

Problem to Solve

Right now, you must have access as a Pods admin (caps: pods, pods_content, or pods_edit_{pod_name}).

It would be great to override what capability check(s) are used for the Custom Settings Pages specifically.

Proposed Solution

Add a new option to the Pod edit screen for Settings pods so that you can choose from these capabilities:

• Default: Anyone with access to pods, pods_content, or pods_edit_{pod_name} capabilities
• Custom
• Specify the custom capability to reference for access

Possible Workaround

add_filter( 'pods_is_admin', 'my_custom_override_for_custom_settings_page_access', 10, 3 );

function my_custom_override_for_custom_settings_page_access( $has_access, $capabilities, $capability ) {
	$my_pod_name = 'my_pod_name_here';
	$my_custom_capability = 'my_custom_capability_here';

	if (
		in_array( 'pods_edit_' . $my_pod_name, $capabilities, true )
		&& current_user_can( $my_custom_capability )
	) {
		return true;
	}

	return $has_access;
}

Todos

• Update access check in PodsAdmin::admin_menu()

  pods/classes/PodsAdmin.php

  Line 477 in 08d1c6a

  if ( ! pods_is_admin( array( 'pods', 'pods_content', 'pods_edit_' . $pod['name'] ) ) ) {

• Add two fields to \Pods\Admin\Config\Pod::get_fields() for Settings pods: capability_type and capability_type_custom

[phkoon]

Much needed.

In my case, I've created a custom settings page with some image fields that serve globally throughout the site and the site manager can't access it due to not having the "manage_options" capability enabled, only an admin user has access to it, and it breaks the purpose for the settings page I've created, and I see no other mean other than creating individual custom fields for every page in which those image fields are needed to be shown.

I've tried giving the "manage_options" capability to the site manager role, but in addition to it not being safe, it didn't work also, the custom settings page only shows up in the menu for admin roles.