Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid captcha when pressing request button twice #23

Open
ligi opened this issue Feb 26, 2019 · 17 comments
Open

Invalid captcha when pressing request button twice #23

ligi opened this issue Feb 26, 2019 · 17 comments

Comments

@ligi
Copy link
Contributor

ligi commented Feb 26, 2019

can be seen in this video: https://youtu.be/ml_5VsMYDcg

ideally pressing request once opens some modal that blocks from pressing a second time

@ligi
Copy link
Contributor Author

ligi commented Mar 15, 2019

a gif for easier access to the video:

resized

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

@deeayeen
Copy link

deeayeen commented Mar 20, 2019

@ligi
Hey Ligi! It's a super simple fix, I'm just running into the following issue.
This repository is for the POA sokol faucet, while the issue you are describing is for the Goerli faucet.

When testing the issue on the POA faucet everything works perfectly:
https://faucet-sokol.herokuapp.com/

When testing the issue on the Goerli faucet it is indeed giving the issue you described:
https://goerli-faucet.slock.it/index.html

Please let me know how I can work on the relevant issue. Thanks!

@ligi
Copy link
Contributor Author

ligi commented Mar 20, 2019

@thereapman should be able to help here - he operates this goerli faucet. Sorry if I opened it on the wrong repo - but on the botom of the goerli faucet it mentions this repo

@deeayeen
Copy link

@ligi

Hey I just checked out the goerli faucet, looks like this issue has already been solved?

@gitcoinbot
Copy link

@deeayeen Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@deeayeen
Copy link

@gitcoinbot @ligi

Please let me know if this is already solved.

@deeayeen
Copy link

@ceresstation @ligi @thereapman

I've stopped working on this issue as my questions are not being answered and it seems as though it has already been solved. Happy to continue if work is still needed, if not please close the issue 👍

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 5 days, 19 hours from now.
Please review their action plans below:

1) devnasim has applied to start work (Funders only: approve worker | reject worker).

can I try this, I love to solve this most challenging issue.
please DM me.
have a nice day!

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@devnasim Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@fnLog0
Copy link

fnLog0 commented Apr 4, 2019

just go through recaptcha form I seem that when a form is submitted. Post request is triggered on the path
'/'.
it's not a better way, just create a post request on path "/verification-captcha or any path", After submission trigger redirection.

@ligi what you say?

@gitcoinbot
Copy link

@devnasim Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Apr 9, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 2 days ago.
Please review their action plans below:

1) internetjohnny has been approved to start work.

My course of action

  • clone repo
  • on the page with the captcha, replace the button action with some javascript that will detect the click
  • detect the first click and block others
  • test and verify that it works as intended

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@InternetJohnny Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@InternetJohnny
Copy link

I am still working on the issue yes. Apologies for the lack of feedback, my schedule this weekend made me unable to get much done. Will be adding something soon.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @internetjohnny

@ceresstation please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @InternetJohnny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@ligi @InternetJohnny @fnLog0 @gitcoinbot @deeayeen and others