Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads are not joined when pnpm -r script is interrupted with SIGINT #8051

Open
2 of 4 tasks
minenwerfer opened this issue May 4, 2024 · 0 comments
Open
2 of 4 tasks

Comments

@minenwerfer
Copy link

minenwerfer commented May 4, 2024

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

v9.0.6

Which area(s) of pnpm are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  • Have multiple workspaces configured
  • Have scripts that take some time to execute
  • Run them in parallel with pnpm -r script then send a CTRL-C in the middle
  • Scripts continue running until they finnish

Describe the Bug

This bug prevents the scripts from being interrupted immediately. A SIGTERM must be send in order to kill the scripts running in parallel. This is likely a regression, I don't remember experiencing the same in v8.

Expected Behavior

Threads/forks should be joined when the main process is interrupted.

Which Node.js version are you using?

v20.6.1

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

Arch Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant