Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error messages when user doesn't specify version #54

Open
kidonng opened this issue Sep 14, 2022 · 4 comments
Open

Confusing error messages when user doesn't specify version #54

kidonng opened this issue Sep 14, 2022 · 4 comments
Assignees

Comments

@kidonng
Copy link

kidonng commented Sep 14, 2022

It seems this action requires a package.json file to be present:

const pkgJson = path.join(dest, 'package.json')
await ensureFile(pkgJson)

Even if users only use pnpx and do not install packages locally, they have to provide a package.json, which is inconvenient.

Will the action support using it without a package.json?

@KSXGitHub KSXGitHub assigned zkochan and unassigned zkochan Sep 14, 2022
@KSXGitHub
Copy link
Collaborator

You misinterpreted the code. Have you tried running this action without package.json?

@kidonng
Copy link
Author

kidonng commented Sep 15, 2022

@kidonng
Copy link
Author

kidonng commented Sep 15, 2022

Ah, I think I got what's happening. I didn't specify a version, so the action is finding the packageManager field in package.json, but I don't have one.

Sorry, my assumption is wrong 🙈

@kidonng kidonng closed this as completed Sep 15, 2022
@KSXGitHub KSXGitHub changed the title Use without package.json Confusing error messages when user doesn't specify version Sep 15, 2022
@KSXGitHub KSXGitHub reopened this Sep 15, 2022
@KSXGitHub
Copy link
Collaborator

I think the error messages can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants