Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile network NBT serialization needs a TypeConverter context #6284

Open
dktapps opened this issue Mar 13, 2024 · 0 comments
Open

Tile network NBT serialization needs a TypeConverter context #6284

dktapps opened this issue Mar 13, 2024 · 0 comments
Labels
BC break Breaks API compatibility Category: Network Related to the internal network architecture Type: Enhancement Contributes features or other improvements to PocketMine-MP
Milestone
6.0

Comments

@dktapps
Copy link
Member

dktapps commented Mar 13, 2024

Description

Spawnable::get(Serialized)SpawnCompound() needs a TypeConverter context

Justification

NBT serialization for network is currently context-unaware, which might be a problem if context-specific stuff gets put into NBT. This previously caused issues for item frames, and is also a potential problem for multi-version forks.

Alternative methods
@dktapps dktapps added Category: Network Related to the internal network architecture Type: Enhancement Contributes features or other improvements to PocketMine-MP BC break Breaks API compatibility labels Mar 13, 2024
@dktapps dktapps added this to the 6.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks API compatibility Category: Network Related to the internal network architecture Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
1 participant
@dktapps