Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate resource pack loading from ResourcePackManager::__construct() #6254

Open
dktapps opened this issue Feb 13, 2024 · 0 comments
Open

Separate resource pack loading from ResourcePackManager::__construct() #6254

dktapps opened this issue Feb 13, 2024 · 0 comments
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Category: Core Related to internal functionality

Comments

@dktapps
Copy link
Member

dktapps commented Feb 13, 2024

Description

As per title. ResourcePackManager should focus on managing packs rather than where to load them from.

Justification

With its expanded API in newer versions, it's possible (perhaps even desirable) to construct a ResourcePackManager entirely using its API, as opposed to having it load packs from a certain folder on the disk.

Alternative methods
@dktapps dktapps added Category: API Related to the plugin API Category: Core Related to internal functionality BC break Breaks API compatibility labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Category: Core Related to internal functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dktapps