Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper limit for async-workers: auto #6213

Open
dktapps opened this issue Dec 30, 2023 · 3 comments
Open

Upper limit for async-workers: auto #6213

dktapps opened this issue Dec 30, 2023 · 3 comments
Labels
Category: Core Related to internal functionality Category: UI Related to the user interface (e.g. commands, terminal output) Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Dec 30, 2023

Description

When set to auto, the server will permit as many workers to run as there are CPU cores. This is counterproductive on server machines with many cores (e.g. more than 8), as PM will rarely make effective use of more than a handful of them.

In addition, each extra thread costs at least 1 MB of RAM, as well as wasting several MB of /tmp because of ext-phar wasteful caching.

A max of 8 should be sufficient. If users want more than 8 workers, they can set the value manually themselves.

@dktapps dktapps added Category: Core Related to internal functionality Type: Enhancement Contributes features or other improvements to PocketMine-MP Category: UI Related to the user interface (e.g. commands, terminal output) labels Dec 30, 2023
@vkamz597
Copy link

@dktapps Is this a problem that directly affects server lag?

@dktapps
Copy link
Member Author

dktapps commented Dec 31, 2023

no

@dktapps
Copy link
Member Author

dktapps commented Jan 3, 2024

Related to #6214 and php/php-src#13055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core Related to internal functionality Category: UI Related to the user interface (e.g. commands, terminal output) Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

2 participants