Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting recipes per player #6208

Open
dktapps opened this issue Dec 26, 2023 · 0 comments
Open

Crafting recipes per player #6208

dktapps opened this issue Dec 26, 2023 · 0 comments
Labels
Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Dec 26, 2023

Description

It's possible that in some circumstances, we may want to have different players have access to different crafting recipes, based on roles, permissions, location, and other things.

While recipe access limiting can technically be implemented by cancelling CraftItemEvent for non-permitted players, it doesn't prevent those players from being able to attempt the crafting in the first place, and accessing it via the recipe book. Cancelling the event this way also leads to a lot of network noise as the items are rolled back to their original states.

This can be implemented similarly to the recent addition of per-player creative inventory (#5694), though in this particular case it may be worth exploring if there are better ways to do this.

Problems

  • There's no obvious way for furnaces and brewing stands to have their recipe selection linked to a player.
  • The crafter in 1.21 (upcoming) makes this extra confusing.
  • There's currently no way to delete crafting recipes (though that would be solved by Allow removing crafting recipes #5664).

Justification

Alternative methods

@dktapps dktapps added Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

No branches or pull requests

1 participant