Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash consistency bug in 3.2-nvml #219

Open
iangneal opened this issue May 3, 2021 · 0 comments
Open

Crash consistency bug in 3.2-nvml #219

iangneal opened this issue May 3, 2021 · 0 comments

Comments

@iangneal
Copy link

iangneal commented May 3, 2021

redis/src/server.c

Lines 4015 to 4019 in 4e622e7

if (server.pm_pool == NULL) {
/* Open the existing PMEM pool file. */
server.pm_pool = pmemobj_open(server.pm_file_path, PM_LAYOUT_NAME);
server.pm_rootoid = POBJ_ROOT(server.pm_pool, struct redis_pmem_root);
server.pm_reconstruct_required = true;

  • If the pool is corrupted or is otherwise unopenable, pmemobj_open(...) will return NULL, causing a SEGFAULT during initialization (i.e., at POBJ_ROOT).
iangneal added a commit to efeslab/redis-pmem that referenced this issue Nov 4, 2021
PatKamin added a commit to PatKamin/redis that referenced this issue Oct 28, 2022
[6.0.2-devel] Fix make test failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant