Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

version is not set in CMake when pmemkv is downloaded as a zip #842

Open
lukaszstolarczuk opened this issue Nov 16, 2020 · 0 comments
Open

Comments

@lukaszstolarczuk
Copy link
Member

Environment Information

pmemkv downloaded as a zip, e.g. from github

Actual behavior:

VERSION variable is not set, hence make package will create a package with empty "version=" parameter and other apps using our library won't be able to check version of our library.

Expected behavior:

VERSION is set somehow

Details

  1. we can use zip name to establish version - GH prepares zip called "pmemkv-master" for master branch
  2. we can hardcode recently released version, like we do in libpmemobj-cpp
@lukaszstolarczuk lukaszstolarczuk removed the new need to be triaged label Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant