Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Add Black - code formatter for python #14

Open
karczex opened this issue Oct 22, 2019 · 5 comments
Open

Add Black - code formatter for python #14

karczex opened this issue Oct 22, 2019 · 5 comments
Labels
Type: Feature New feature or request

Comments

@karczex
Copy link

karczex commented Oct 22, 2019

ref: https://fedoramagazine.org/make-your-python-code-look-good-with-black-on-fedora/

@lukaszstolarczuk lukaszstolarczuk added the Type: Feature New feature or request label Dec 5, 2019
@hamzzy
Copy link

hamzzy commented Jan 6, 2021

can it be add to github action when ever a push is made

@lukaszstolarczuk
Copy link
Member

@hamzzy, we haven't discussed this feature yet, but if you're saying we should automatically format code (and also automatically commit possible changes) on push then we are not fans of such solution.
We usually just deliver code formatter for us/developers to use, and on CI we only check if code format is proper and fail otherwise - is that good enough for you?

@hamzzy
Copy link

hamzzy commented Jan 7, 2021

okay cool.

@hamzzy
Copy link

hamzzy commented Jan 7, 2021

Also, the python wrapper isn't documented.
I don't know if such is a need.

I would love to contribute to such.

@lukaszstolarczuk
Copy link
Member

Also, the python wrapper isn't documented.
I don't know if such is a need.

I would love to contribute to such.

We do have a documentation, it's available in the code and generated as html in here:
https://pmem.io/pmemkv-python/

but we always appreciate any contributions, either pull requests or issues, so feel free to work with us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants