Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

preload_basic_commands test fails when executed from root #289

Open
marcinslusarz opened this issue Aug 3, 2017 · 6 comments
Open

preload_basic_commands test fails when executed from root #289

marcinslusarz opened this issue Aug 3, 2017 · 6 comments
Labels

Comments

@marcinslusarz
Copy link
Contributor

It takes write permission from a file and expects overwriting it should fail.

@GBuella
Copy link
Contributor

GBuella commented Aug 3, 2017

Those tests should not be run as root.

@marcinslusarz
Copy link
Contributor Author

I agree. We just need to detect it and refuse to run tests at all (I think it's preferred) or skip some of them.

@GBuella
Copy link
Contributor

GBuella commented Aug 3, 2017

Yup, libpmemfile should just abort when root.

@marcinslusarz
Copy link
Contributor Author

libpmemfile tests, not libpmemfile!

@GBuella
Copy link
Contributor

GBuella commented Aug 3, 2017

Well, both, that is the best.

@marcinslusarz
Copy link
Contributor Author

Then we wouldn't be able to test libpmemfile with pjdfstest. And I don't see any problem with handling root correctly. We already support chown, capabilities affecting file APIs, setuid & co.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants