Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson issues #224

Open
tristan957 opened this issue Sep 27, 2022 · 1 comment
Open

Meson issues #224

tristan957 opened this issue Sep 27, 2022 · 1 comment

Comments

@tristan957
Copy link

All the root*dir logic is unnecessary. Subprojects inherit the standard directories from the root project. I don't really know why there is an iniparserdir option. Please remove it because if I have a prefix in the root project of /opt/cxl-reskit, then Meson fails looking for the iniparser headers in /opt/cxl-reskit/include because the prefix doesn't exist.

if get_option('systemd').enabled()
  systemd = dependency('systemd', required : true)
  systemdunitdir = systemd.get_pkgconfig_variable('systemdsystemunitdir')
  udev = dependency('udev', required : true)
  udevdir = udev.get_pkgconfig_variable('udevdir')
  udevrulesdir = udevdir / 'rules.d'
endif

You are effectively making -Dsystemd a boolean instead of a feature with this logic.

Please use meson.override_find_program() and meson.override_dependency() as necessary for an binaries and dependencies.

These are just a few issues that I have had trying to consume this build system.

@tristan957
Copy link
Author

I can refer you to a Meson maintainer within Intel if help is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant