Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

concurrent_hash_map tests fail to compile with newset (2021) tbb #990

Open
igchor opened this issue Dec 7, 2020 · 2 comments
Open

concurrent_hash_map tests fail to compile with newset (2021) tbb #990

igchor opened this issue Dec 7, 2020 · 2 comments
Labels
new need to be triaged Priority: 2 high State: Blocked Waiting for other components/fixes/etc. Type: Bug Something isn't working

Comments

@igchor
Copy link
Contributor

igchor commented Dec 7, 2020

ISSUE: concurrent_hash_map tests fail to compile with newset (2021) tbb

Environment Information

  • libpmemobj-cpp version(s): master
  • PMDK (libpmemobj) package version(s):
  • OS(es) version(s):
  • kernel version(s):
  • compiler, libraries, packaging and other related tools version(s):

and possibly:

  • TBB version(s): 2021
  • ndctl version(s):

Please provide a reproduction of the bug:

make

How often bug is revealed:

always

Details

In tbb 2021 name of some protected members in tbb:spin_rw_mutex::scoped_locke were change (is_write -> m_is_write). Since we use them in concurrent_hash_map in tests with tbb there is a compilation error.

Additional information about Priority and Help Requested:

Are you willing to submit a pull request with a proposed change? (Yes, No)

Requested priority: (Showstopper, High, Medium, Low)

@igchor igchor added the Type: Bug Something isn't working label Dec 7, 2020
@lukaszstolarczuk lukaszstolarczuk added the new need to be triaged label Dec 7, 2020
@pbalcer
Copy link
Member

pbalcer commented Dec 7, 2020

ideally, you'd remove the dependency on internal variables entirely since the alternative approach would be to include a compile-time version check.

@igchor
Copy link
Contributor Author

igchor commented Dec 7, 2020

Yes, tbb should expose a public interface to query for the information we need (whether the lock is in read or write mode).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new need to be triaged Priority: 2 high State: Blocked Waiting for other components/fixes/etc. Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants