Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Generated [deb] package contains compatibility tests #1056

Open
lukaszstolarczuk opened this issue Mar 15, 2021 · 0 comments
Open

Generated [deb] package contains compatibility tests #1056

lukaszstolarczuk opened this issue Mar 15, 2021 · 0 comments
Labels
new need to be triaged Type: Bug Something isn't working

Comments

@lukaszstolarczuk
Copy link
Member

Environment Information

  • libpmemobj-cpp version(s): current master (e.g. 1.12-42-geca8f5f8)
  • tested on Ubuntu 20.10
  • Cmake flag TESTS_COMPATIBILITY is set

Please provide a reproduction of the bug:

cd build
cmake .. -DTESTS_COMPATIBILITY=ON -DCPACK_GENERATOR="DEB"
make package

How often bug is revealed:

always

Actual behavior:

Generated deb package (and probably rpm as well) contains the compatibility tests' sources and hence the old versions of libpmemobj-cpp

Expected behavior:

We should at least print a warning in CMake (with info is not recommended) or just test compatibility in different way (e.g. like in pmemkv)

@lukaszstolarczuk lukaszstolarczuk added the Type: Bug Something isn't working label Mar 15, 2021
@lukaszstolarczuk lukaszstolarczuk added the new need to be triaged label Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new need to be triaged Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant