Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential XSS flaw #59

Open
wiredin opened this issue Jun 5, 2017 · 0 comments
Open

Potential XSS flaw #59

wiredin opened this issue Jun 5, 2017 · 0 comments

Comments

@wiredin
Copy link

wiredin commented Jun 5, 2017

In middleware.rb, a request parameter is passed directly to the response body without being escaped.
id = request.params['id']

the parameter should be wrapped in html_escape to prevent possible XSS
id = html_escape(request.params['id'])

Please see this example URI as proof:
simple_captcha/?id=%22)%3B%20%3Cscript%20type=%27text/javascript%27%3Ealert(%27xss%27](url))%3B%3C/script%3E%20%23(%22

@hendrixfan hendrixfan self-assigned this Dec 8, 2019
@hendrixfan hendrixfan removed their assignment Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants