Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general CI cleanup #987

Open
edublancas opened this issue Jan 25, 2024 · 2 comments
Open

general CI cleanup #987

edublancas opened this issue Jan 25, 2024 · 2 comments

Comments

@edublancas
Copy link

we have some minor issues in our CI that we need to fix:

  • update documentation for this file it says it's for Snowflake but it's also for redshift. we need to give a quick check and ensure the documentation at the top of the file is accurate
  • the github actions files are a bit inconsistent and inaccurate, let's see if we can come up with better names
  • address this issue
@edublancas edublancas added the stash Label used to categorize issues that will be worked on next label Jan 25, 2024
@neelasha23
Copy link

Adding a note:
clickhouse-sqlalchemy supports sqlalchemy > 2 : https://github.com/xzkostyan/clickhouse-sqlalchemy/blob/c5eda6dd5cb621684e56af4abd3de4c8e000f965/setup.py#L99

But the docker image is probably not supporting (need to check this).

@edublancas
Copy link
Author

the docker image only has clickhouse installed so my guess is that it should be independent from the sqlalchemy version

unless they had to make changes to clickhouse for sqlalchemy 2.x to work, but I doubt it. but let me know what you find!

@edublancas edublancas removed the stash Label used to categorize issues that will be worked on next label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants