Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab settings not respected #1010

Open
psychemedia opened this issue May 8, 2024 · 2 comments
Open

JupyterLab settings not respected #1010

psychemedia opened this issue May 8, 2024 · 2 comments
Labels
bug Something isn't working stash Label used to categorize issues that will be worked on next

Comments

@psychemedia
Copy link

What happens?

Initialising a new jupyterlab environment with default settings to disable the display of the Share notebook and Format SQL toolbar buttons, the settings are not respected although the settings editor describes them correctly.

image

Enabling then disabling the setting from the settings panel does then correctly hide the buttons.

To Reproduce

I used the following settings:

In .jupyter/lab/user-settings/ploomber-extension/settings.jupyterlab-settings:

{
    "showShareNotebook": false
}

In .jupyter/lab/user-settings/jupysql-plugin/settings.jupyterlab-settings:

{
    "showFormatSQL": false
}

Start the jupyter server, open a notebook, and the buttons are displayed.

OS:

Linux Ubuntu

JupySQL Version:

0.10.10

Full Name:

Tony Hirst

Affiliation:

The Open University

@psychemedia
Copy link
Author

Actually, another way to recreate is just to untick the settings in the Jupyterlab extensions settings, then open a new notebook,. The new notebook displays the buttons. If you then tick and untick then tick the settings, the button remains, disappears, reappears.

So the decision to decide whether or not to display a button when the notebook is opened is broken,

JupyterLab Version 4.2.0

@edublancas
Copy link

thanks, we'll look at this

in the meantime, you can try uninstalling jupysql-plugin after installing jupysql, that should remove both buttons

@edublancas edublancas added bug Something isn't working stash Label used to categorize issues that will be worked on next labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stash Label used to categorize issues that will be worked on next
Projects
None yet
Development

No branches or pull requests

2 participants