You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes initialValue block setting in two situations:
When the previous block is an empty block:
In this situation, only the onChangeBlock method was called, which does not call the applyBlockInitialValue method. Then we call the applyBlockInitialValue method before calling onChangeBlock.
When the previous block is not an empty block:
In this situation, the insertBlock method is called. But it passed the id of the previous block to the applyBlockInitialValue method, instead of the id of the new created block.
The reason will be displayed to describe this comment to others. Learn more.
@wesleybl Usually when you have a method that starts with _ it's implied that it is private.
I don't think it should thus be exported for helpers, if that is the case that it would be useful
for add-ons to call this helper then I would remove the _.
Ex info https://css-tricks.com/implementing-private-variables-in-javascript/#aa-using-an-underscore
but if you google js private convention you will see that this was very popular before true private
fields
The reason will be displayed to describe this comment to others. Learn more.
@ichim-david I thought about this when I was implementing it, but I thought renaming a function could be a big change. But as it was a local function of the module, I don't think it will be a big problem. I'll rename it.
In this situation, only the onChangeBlock method was called, which does
not call the _applyBlockInitialValue method. Then we call the
_applyBlockInitialValue method before calling onChangeBlock.
block
In this situation, the insertBlock method is called. But it passed the
id of the previous block to the _applyBlockInitialValue method, instead
of the id of the new created block.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
initialValueblock setting in two situations:In this situation, only the
onChangeBlockmethod was called, which does not call theapplyBlockInitialValuemethod. Then we call theapplyBlockInitialValuemethod before callingonChangeBlock.In this situation, the
insertBlockmethod is called. But it passed the id of the previous block to theapplyBlockInitialValuemethod, instead of the id of the new created block.fixes #5971