Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes navigation settings that are not used by Volto #5964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes navigation settings that are not used by Volto #5964

wants to merge 1 commit into from

Conversation

wesleybl
Copy link
Member

fixes: #5961

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit ef5da04
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66315ae30e79a90008e7ae78

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit ef5da04
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/66315ae3fe3d1500082e3983

davisagli
davisagli reviewed Apr 29, 2024
View reviewed changes
packages/volto/src/config/ControlPanels.js Outdated
navigation: [
'generate_tabs',
'navigation_depth',
'nonfolderish_tabs',
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is used here: https://github.com/plone/plone.restapi/blob/main/src/plone/restapi/services/navigation/get.py#L116

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.

@wesleybl wesleybl requested a review from davisagli April 30, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh Awaiting requested review from sneridagh

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove navigation settings that are not used by Volto
2 participants
@wesleybl @davisagli