Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect assumption about value of cells in slate table #5947

Open
tiberiuichim opened this issue Apr 5, 2024 · 2 comments
Open

Incorrect assumption about value of cells in slate table #5947

tiberiuichim opened this issue Apr 5, 2024 · 2 comments

Comments

@tiberiuichim
Copy link
Contributor

cell.value && Node.string({ children: cell.value }).length > 0

If I have an image (volto-slate can render images inside tables), then it won't be rendered because the string content of that image is nil.

@davisagli
Copy link
Sponsor Member

What was that code trying to do?

@tiberiuichim
Copy link
Contributor Author

@davisagli I think it was trying to avoid rendering empty paragraphs, or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants