Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast not working after the upgrade of react-toastify to version v5.5.0 #5895

Open
dobri1408 opened this issue Mar 19, 2024 · 3 comments
Open
Assignees
Labels
01 type: bug 30.1 needs: confirmation An old issue that needs to be reviewed for whether it still exists.

Comments

@dobri1408
Copy link
Contributor

dobri1408 commented Mar 19, 2024

Describe the bug
The toast is not showing.

To Reproduce
The problem can be replicable if you customize a file with the toast.succes(), or toast.error() function in it. The toast from that file that you customized will not be working, even if you put the same file in customization. This issue is not happening if you put it back to version v5.4.1 which was before this commit https://github.com/plone/volto/pull/5835/files

Expected behavior
It should work even if you customize such a file

Software (please complete the following information):

  • OS: [e.g. MAC OS]
  • Browser [firefox]
  • Volto Version [>16.31.2]
  • Plone Version [e.g. 6]

Additional context

@dobri1408 dobri1408 changed the title The upgrade of react-toastify to version v5.5.0 Toast not working after the upgrade of react-toastify to version v5.5.0 Mar 19, 2024
@dobri1408
Copy link
Contributor Author

@robgietema

@ichim-david ichim-david reopened this Apr 1, 2024
@ichim-david ichim-david added this to the 16.x.x milestone Apr 1, 2024
@ichim-david ichim-david added the 30.1 needs: confirmation An old issue that needs to be reviewed for whether it still exists. label Apr 1, 2024
@davisagli
Copy link
Sponsor Member

@dobri1408 I tried to reproduce this, but toasts are working fine in a customized file in a project we have on Volto 16.31.4.

It might help if you share which file you customized and what is in the customized file. Also, are there any errors in the console?

@ichim-david
Copy link
Sponsor Member

@davisagli I might of reopened the issue too soon, I've added the needs: confirmation label for the reason that we need to confirm it's an actual bug.
I didn't appreciate that the bug report was closed without any comment for why it seemed "completed".
Since he is my colleague I will work together with him to get the reproducible test case, I have a feeling it might happen from other add-ons we have at EEA and not directly an issue of Volto core.

@ichim-david ichim-david self-assigned this Apr 2, 2024
@sneridagh sneridagh removed this from the 16.x.x milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 type: bug 30.1 needs: confirmation An old issue that needs to be reviewed for whether it still exists.
Projects
None yet
Development

No branches or pull requests

4 participants