Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In api.content.create, avoid renaming object if "id" was not given #439

Open
gbastien opened this issue Feb 28, 2020 · 2 comments · May be fixed by #484
Open

In api.content.create, avoid renaming object if "id" was not given #439

gbastien opened this issue Feb 28, 2020 · 2 comments · May be fixed by #484
Assignees
@ale-rt
Labels
04 type: enhancement

Comments

@gbastien
Copy link
Member

Hi @jensens @ale-rt

we discovered that when creating an element using content.create without specifying an "id", it was created then renamed, this cause ContainerModified event to be called 2 times (and some other events too).

I wondered why this was done in 2 steps? Could it be done before creating the element?
https://github.com/plone/plone.api/blob/master/src/plone/api/content.py#L118
Actually the element is created and if id is not given, then it is renamed to a computed id.
I think we could check if "id" is given, then generate it and pass it to invokeFactory instead renaming it after?
Or is there some reason why it is done after?

We could propose a PR "solving" this.

We avoid this by passing a generated id to content.create now.

Thank you,

Gauthier
@ale-rt
Copy link
Member

ale-rt commented Feb 28, 2020

👍 that is a thing which is also annoying me.
I also almost always pass the id to avoid the object to be moved after creation.

But I fear that in some cases this can be hard.

The auto generated id might be based:

  • the title (e.g. pages or folders)
  • file
  • image
  • whatever your custom logic wants

Now the object is created using container.invokeFactory(type, content_id, **kwargs).
The parameter content_id is either the id which is passed by the user or a generated one.
I bet some lower level method that does not attach the object to the container could be used.

Anyway if you could make a PR to fix this I will be super happy to review it.
If we do not manage to fix this, we should document what is happening very precisely.

IIRC this is not the first time this topic is dicussed.

@jensens
Copy link
Sponsor Member

jensens commented Feb 28, 2020

+1000

@jensens jensens removed their assignment Feb 28, 2020
ale-rt added a commit that referenced this issue May 18, 2022
@ale-rt
Use the dexterity machinery in api.content.create
5bead9f 
Fixes #439
@ale-rt ale-rt linked a pull request May 18, 2022 that will close this issue
Draft
ale-rt added a commit that referenced this issue May 19, 2023
@ale-rt
Use the dexterity machinery in api.content.create
5ec99d9 
Fixes #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ale-rt ale-rt

Labels
04 type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the dexterity machinery in api.content.create plone/plone.api
3 participants
@jensens @gbastien @ale-rt